P12: Windows e2e shard 2/10 (every outcome class alone) takes 10 min

Open
#118 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
github-actions, javascript
Domain
ci-cd, testing

Research direction

Start with scripts/pr-shards.mjs and the oracle-gaps-fixed-seed-windows shard assignment, then inspect the every outcome class unit and its Windows end-to-end runtime. Compare the three proposed paths: split the witness history, record a P12 exception, or reduce the Windows cost of the hang witnesses. Done means the shard is under the 10-minute budget and its reach checks still pass, or the maintainer records an exception.

Written by the indexing model from the issue text.

Description

windows

Summary

The Windows e2e job Windows gap report end-to-end oracle (fixed seed, 2/10) runs one unit, fixed seed 20261105: every outcome class. On PR #115 it took 10m05s (run 43783774902, job 133026717354; the unit alone took 562 s). On main it took 9m13s (run 43693786590, job 132749781500). That is over, or at, the P12 budget of 10 minutes per job.

#115 does not cause it. Its only change is an oracle comparison that is linear in the number of gap lines, and the unit takes as long on main. The job also fails on main and on #115 on the reach gate: "did not enter a hang cut off for idleness". That is the Windows idle gap recorded in the e2e oracle's Limits, and #99 owns it.

Why the shard can't be split

Shard 2/10 already holds this one unit (scripts/pr-shards.mjs, oracle-gaps-fixed-seed-windows, shard 2). Splitting the job means splitting the constructed history itself, as #73 did when it moved the warm and abort stops into every outcome class, the warm and abort stops. Or the witness module's win32 cost must come down.

Options (for the maintainer)

  1. Split every outcome class again, for example the hang and slow witnesses apart from the rest. The framework checks reach over the union of the halves, as it does for the current split.
  2. Record a win32 exception to P12 for this unit while the Windows e2e jobs are non-blocking (C entry (c)).
  3. Reduce the win32 cost of the hang witnesses: the idle sampler's window and the backstop.

Related: #106, the same P12 problem for the witness module's determinism unit on Linux.

Authority

P12 (register): every CI job stays under 10 minutes, and the cost comes from real cuts first and sharding second.

Dominant language
JavaScript
Stars
5
Forks
1
Avg merge
6h
Merged PRs (30d)
56

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TanStack/oracles

All issues in TanStack/oracles

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.