Reorder static checks by performance and warning probability

Open Beginner friendly
  • Is something wrong?
#2,456 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
bash, php
Domain
tooling

Research direction

The checkStatic function in runTests.sh and the check:static script in composer.json each call the same set of static checks. Read both to see the current order, then reorder them to match the sequence listed in the issue. Done when both lists run in the proposed order and the script still exits non-zero on the first failing check.

Written by the indexing model from the issue text.

Description

runTests.sh

Story

As a developer, I want the checkStatic script from runTests.sh and the check:static Composer script to run the scripts in an order that has faster checks first and checks that tend to catch problems more often first so that I can work faster and have less irrelevant output.

Acceptance criteria

  • The scripts called by the checkStatic script are sorted as listed below.
  • The scripts called by the check:static Composer script are sorted as listed below.

Additional information

Proposed order:

         lintPhp &&
         cgl &&
         phpstan &&
         rector &&
         composerNormalize &&
         lintTypoScript &&
         lintYaml &&
         lintJson &&
         checkIntegrityXliff &&
         normalizeXliff &&
         psrVerify &&
         composerUnused
Dominant language
PHP
Stars
92
Forks
34
Avg merge
12h 23m
Merged PRs (30d)
78

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TYPO3BestPractices/tea

All issues in TYPO3BestPractices/tea

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.