Follow-up to #6661: Reboot sync: a watch fault after activity creation must report the import still running
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #6661 by @rbuergi — merged
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 40/100
Research direction
Start from the reboot sync code that calls onActivityCreated and the catch around the terminal-status watch, where StillRunning is set to null. Trace how Sequence decides to start the next import, and read the pull request #6661 discussion for the intended behaviour. Write a failing test where the watch faults after activity creation and expect StillRunning to be returned, then make the fix. Done when that test passes and pre-creation failures still let the sequence continue.
Written by the indexing model from the issue text.
Description
Follow-up to #6661 (review findings deferred from that pull request; Refs #6661).
- If the terminal-status watch faults after
onActivityCreated, the catch reportsStillRunning = nullandSequencestarts the next import while the first may still write. Keep the created activity path and return it as still running for every post-creation watch failure; only pre-creation failures may let the sequence continue.
These are automated-review findings, assessed from the diff and not reproduced; each needs a failing test before its fix. Deferred from the PR because CI is saturated and none of them is a security hole, data loss or a broken build/test.
- Dominant language
- C#
- Stars
- 12
- Forks
- 5
- Avg merge
- 5h 44m
- Merged PRs (30d)
- 968
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Systemorph/MeshWeaver
-
bug sev:M
Difficulty 4/5 3-5 days Newbie friendliness 12/100
Systemorph/MeshWeaver#6857 · 1 comment ·
Maintainers usually reply within 1 day
-
bug sev:M
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Systemorph/MeshWeaver#6856 ·
Maintainers usually reply within 1 day
-
bug sev:M
Difficulty 4/5 3-5 days Newbie friendliness 18/100
Systemorph/MeshWeaver#6853 · 3 comments ·
Maintainers usually reply within 1 day
-
bug sev:H
Difficulty 4/5 3-5 days Newbie friendliness 18/100
Systemorph/MeshWeaver#6850 ·
Maintainers usually reply within 1 day
-
bug cli-publish-failure feature:release-promotion sev:M
Difficulty 3/5 1-3 hours Newbie friendliness 12/100
Systemorph/MeshWeaver#6845 ·
Maintainers usually reply within 1 day
All issues in Systemorph/MeshWeaver
Similar issues
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
7.0
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
unoplatform/uno.extensions#3253 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Sector-Vestige/Sector-Vestige#476 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
PowerShell/platyPS#868 ·
-
S: Untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Trauma-Station/Trauma-Station#5058 ·
Maintainers usually reply within 1 day