CreateNode deadline timer retains disposed mesh hub until operation budget
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
Research direction
Start from MeshExtensions.HandleCreateNodeRequest and the Timeout.Absolute fallback that captures the handler closure, then trace what MessageHub the closure still references. Run MeshHubDisposalLeakTest.MeshHub_IsCollected_AfterMeshAndServiceProviderDisposal to reproduce. Done when that test passes, the create lifecycle tests stay green, and the post-creation timer callbacks are cleared when the handler chain ends.
Written by the indexing model from the issue text.
Description
Symptom
Plugins PR #3159 CI run 37756688023 failed MeshHubDisposalLeakTest.MeshHub_IsCollected_AfterMeshAndServiceProviderDisposal with a non-stack GC root after the mesh and service provider were disposed. The ClrMD path was:
LocalScheduler.WorkItem → Timeout.Absolute → Defer → MeshExtensions.HandleCreateNodeRequest closure → MessageHub
The sampled create and update had completed before disposal. Rx 7's LocalScheduler keeps a cancelled absolute-deadline work item in its priority queue until its due time. The create deadline's fallback observable captured the whole handler closure, including the hub. The post-creation timer also captured its callback after cancellation.
Fix and verification
Keep only the path, budget, and current stage in the timeout fallback. Clear the post-creation timer callbacks when the handler chain terminates. Preserve the existing deadline and create response behavior. Verify Release builds, create lifecycle tests, and the Plugins host disposal test using the changed core revision.
CI evidence: https://github.com/Systemorph/MeshWeaver.Plugins/actions/runs/37756688023/job/113251221898
- Dominant language
- C#
- Stars
- 12
- Forks
- 5
- Avg merge
- 5h 44m
- Merged PRs (30d)
- 968
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Systemorph/MeshWeaver
-
bug sev:M
Difficulty 4/5 3-5 days Newbie friendliness 12/100
Systemorph/MeshWeaver#6857 · 1 comment ·
Maintainers usually reply within 1 day
-
bug sev:M
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Systemorph/MeshWeaver#6856 ·
Maintainers usually reply within 1 day
-
bug sev:M
Difficulty 4/5 3-5 days Newbie friendliness 18/100
Systemorph/MeshWeaver#6853 · 3 comments ·
Maintainers usually reply within 1 day
-
bug sev:H
Difficulty 4/5 3-5 days Newbie friendliness 18/100
Systemorph/MeshWeaver#6850 ·
Maintainers usually reply within 1 day
-
bug cli-publish-failure feature:release-promotion sev:M
Difficulty 3/5 1-3 hours Newbie friendliness 12/100
Systemorph/MeshWeaver#6845 ·
Maintainers usually reply within 1 day
All issues in Systemorph/MeshWeaver
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Sector-Vestige/Sector-Vestige#476 ·
Maintainers usually reply within 1 day
-
S: Untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Trauma-Station/Trauma-Station#5058 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
HoffmanEngineering/3d-print-log-api#243 ·
Maintainers usually reply within 1 day
-
:books: documentation untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day