Can't select a duplicate line from the waveform timeline unless I restart SE

Closed
#16,500 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
desktop-dev

Research direction

Reproduce the reported workflow: duplicate a subtitle line, adjust its start and duration, then try selecting the duplicate in the waveform timeline. Start by locating the waveform timeline's hit-testing and selection logic; the issue names no files or tests. Done means clicking the non-overlapping duplicate selects it without restarting Subtitle Edit.

Written by the indexing model from the issue text.

Description

To work with big lines that needs splitting, I'm usually doing duplicate -> set start and keep duration with shortcuts while being at the end of the 1st part. And then edit to have the text split where I want it to.

However, when I try to select the 2nd part (the duplicate) from the waveform timeline, it selects the 1st (source) instead, even if they're not overlapping.

I don't think this is intended, as I can fix this by restarting SE, but it's making this way of working with big lines a bit unpractical for me.

Example here is me trying to click the edited duplicate but selecting the source before it, also showing that they're not overlapping in the timeline.
Image

Dominant language
C#
Stars
14.8k
Forks
1.4k
Avg merge
1h
Merged PRs (30d)
665

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SubtitleEdit/subtitleedit

All issues in SubtitleEdit/subtitleedit

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.