[bug] Playback stops before reaching the end of media in v5.4.0-beta5, works correctly in v4.0.16

Open
  • Is something wrong?
#16,356 7 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
backend, desktop

Research direction

Start by tracing playback near the end of a media file in the v5.4.0-beta5 code, especially the libmpv OpenGL playback path, and compare its behavior with v4.0.16. Reproduce with the attached subtitle and AAC audio files, checking why playback stops around 00:28:36 before subtitle #321. Done means playback reaches the actual media end as expected.

Written by the indexing model from the issue text.

Description

Description

I found a playback issue in Subtitle Edit v5.4.0-beta5.

The same subtitle file and audio file (.aac file) can be played completely in Subtitle Edit 4.0.16, but in v5.4.0-beta5 playback stops prematurely near the end of the media.

Steps to Reproduce
  1. Open the attached .srt file and corresponding audio file.
  2. Start playback near the end of the file.
  3. Let playback continue until the last subtitle entries.
Expected Behavior

Playback should continue until the actual end of the audio/media file, as it does in Subtitle Edit 4.0.16.

Actual Behavior

In v5.4.0-beta5, playback stops unexpectedly around subtitle #320 and does not continue to the final subtitle (#321), even though there is still remaining media to play.

Comparison

Subtitle Edit 4.0.16 (works correctly)

  • Playback reaches the end of the audio.
  • Final subtitle (#321) is reached and displayed.
  • Media time progresses normally to the end.

Subtitle Edit v5.4.0-beta5 (problem)

  • Playback stops while subtitle #320 is still active.
  • Final subtitle (#321) is never reached automatically.
  • There is still remaining media/audio after playback stops.
Additional Information

Observed timestamps:

  • Subtitle #320: 00:28:34.786 --> 00:28:44.486
  • Subtitle #321: 00:28:44.519 --> 00:28:45.020

In v4.0.16, playback continues through both subtitles and reaches the end normally.

In v5.4.0-beta5, playback stops around 00:28:36, leaving several seconds of media unplayed.

Environment
  • Subtitle Edit version: 5.4.0-beta5
  • Working version: 4.0.16
  • Operating System: Windows
  • Video player engine shown in UI: libmpv OpenGL
Attachments

I have attached screenshots showing:

  1. v5.4.0-beta5 stopping playback prematurely.
  2. v4.0.16 successfully reaching the end of the file.

Please let me know if you would like the sample subtitle and audio files for testing.

Image Image
Dominant language
C#
Stars
14.8k
Forks
1.4k
Avg merge
58m
Merged PRs (30d)
697

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SubtitleEdit/subtitleedit

All issues in SubtitleEdit/subtitleedit

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.