test(evaluators): edge cases for the numeric comparison evaluators
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
Research direction
Start with tests/core/evaluators/test_greater_than.py, test_greater_than_equal_to.py, test_less_than.py, and test_less_than_equal_to.py, then compare their existing integer pass and fail cases. Add coverage for equal values, floats, None input, and string-versus-number comparisons in each file, keeping evaluator code unchanged. Run pytest tests/ and black --line-length 120 before opening the PR.
Written by the indexing model from the issue text.
Description
Problem
test_greater_than.py, test_greater_than_equal_to.py, test_less_than.py and test_less_than_equal_to.py in tests/core/evaluators/ each test one pass and one fail with integers. Nothing covers None, floats, equal values or mixed types, where > raises and the evaluator falls back to the exception message.
What to change
Tests only; no evaluator code changes. If a case exposes a wrong verdict, note it in the PR and we'll open a follow-up.
Done when
Each of the four files covers: equal values, floats, None input, and a string compared with a number.
Comment to claim this issue and wait to be assigned. Unclaimed or inactive for 3 days, it returns to the pool. Run pytest tests/ and black --line-length 120 before opening the PR.
- Dominant language
- Python
- Stars
- 167
- Forks
- 47
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 12
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from StackGuardian/tirith
-
research
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
StackGuardian/tirith#356 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
StackGuardian/tirith#302 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
StackGuardian/tirith#299 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
StackGuardian/tirith#295 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
StackGuardian/tirith#294 ·
Maintainers usually reply within 1 day
All issues in StackGuardian/tirith
Similar issues
-
needs-human needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
gke-labs/kube-agents#2400 · 1 comment ·
Maintainers usually reply within 1 day
-
Device Details tables: FS/SF columns contradict each other (nfet_01v8 Vt row, pfet_01v8 Idsat row)Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
google/skywater-pdk#450 ·
-
Drained trajectory arrays are overwritten when the sequence buffer is reusedPossibly taken @sylvesterkaczmarek claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
google-deepmind/bsuite#56 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
LearningCircuit/local-deep-research#7206 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
chingu-voyages/V62-tier3-team-33#285 ·
Maintainers usually reply within 1 day