Replace double with deterministic money representation
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Quiet
- Domain
- backend-api-design, fintech-quant
Research direction
Start by reading the listed money fields and calculation entry points: Split.amount, Expense.amount, Settlement.amount, calculation_utils.dart, settlement.dart, and validation_utils.dart. Check PR #40 for related context, then trace how values are validated and used in settlement calculations. Done means money uses integer cents consistently, validation and calculations are updated, and the unit tests cover the changed behavior.
Written by the indexing model from the issue text.
Description
Summary
CodeRabbit identified potential precision issues caused by using double for monetary values in financial calculations.
Problem
Financial values should use a deterministic representation to avoid floating-point rounding errors.
Affected areas:
- Split.amount
- Expense.amount
- Settlement.amount
- calculation_utils.dart
- settlement.dart
- validation_utils.dart
Proposed Solution
- Replace money values with integer cents representation
- Update validation logic
- Update settlement calculations
- Update unit tests
Reference
Related to PR #40
- Dominant language
- Dart
- Stars
- 20
- Forks
- 39
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from StabilityNexus/Zplit
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
StabilityNexus/Zplit#77 · 1 comment ·
-
[GOOD FIRST ISSUE] [MINOR BUG]: Website uses default starter favicon instead of official Zplit logoPossibly taken A pull request linked to this issue is open or already merged. Opengood first issue
Difficulty 1/5 1-3 hours Newbie friendliness 82/100
StabilityNexus/Zplit#73 ·
-
[FEATURE]: Enhancement of Onboarding Screen and Low Res AssetsPossibly taken A pull request linked to this issue is open or already merged. Openenhancement
Difficulty 3/5 1-2 days Newbie friendliness 61/100
StabilityNexus/Zplit#75 · 2 comments ·
-
[GOOD FIRST ISSUE]: Documentation Cleanup - Addition of Contribution.mdPossibly taken @Logic769 claimed this 20 days ago. Opengood first issue
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
StabilityNexus/Zplit#64 · 2 comments ·
-
gsoc
Difficulty 4/5 3-5 days Newbie friendliness 48/100
StabilityNexus/Zplit#56 ·
All issues in StabilityNexus/Zplit
Similar issues
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
🚀 [firebase_core] Bump Firebase C++ SDK (14.1.0 → 14.2.0)Possibly taken @SelaseKay claimed this today. OpenNeeds Attention type: enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
firebase/flutterfire#18977 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
-
agent: is checked on a wrapper holding several checkables answers from the first one in tree orderOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
AlphaWaveSystems/flutter-probe#865 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
ubuntu/app-center#2306 ·
Maintainers usually reply within 1 day