BUG: Inconsistent Prop Naming (Drilling)
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript, react
Research direction
Read Widget.jsx and TransactionReview.jsx to trace how onSuccess and onTransactionComplete are accepted and passed down. Decide which callback name is the intended standard from the existing implementations, then check the related usage and tests. Done means the callback naming is consistent across both components and the relevant behavior remains covered.
Written by the indexing model from the issue text.
Description
[y] I have checked for duplicate issues
Description
The Widget component accepts onTransactionComplete OR onSuccess (for backward comp), but allows TransactionReview only to accept onTransactionComplete. While currently handled by a variable assignment, this inconsistent naming convention makes the API surface unclear for developers reading the implementations.
How to Reproduce
- Inspect Widget.jsx: accepts onSuccess.
- Inspect TransactionReview.jsx: accepts onTransactionComplete.
Expected Behavior
The SDK should have a standardized casing and naming convention for event callbacks passed down the tree.
Actual Behavior
The props are aliased inside Widget.jsx: const handleTransactionComplete = onTransactionComplete || onSuccess;.
[y] I want to work on this issue
- Dominant language
- JavaScript
- Stars
- 16
- Forks
- 29
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from StabilityNexus/StablePay
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
StabilityNexus/StablePay#64 · 1 comment ·
-
[BUG]: Missing SDK API documentation and incomplete developer-facing usage guide in StablePay READMEOpenbug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
StabilityNexus/StablePay#104 · 1 comment ·
-
[BUG]: `stablepay-sdk` README documents an unrelated thirdweb app instead of the actual SDK APIOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
StabilityNexus/StablePay#102 ·
-
[FEATURE]: Centralize transaction initialization and quote fetching to avoid duplicate RPC calls in the widgetMay be free again @CaptainLevi2k04 claimed this 81 days ago, and no pull request is open. Openenhancement
Difficulty 4/5 3-5 days Newbie friendliness 38/100
StabilityNexus/StablePay#101 · 1 comment ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
StabilityNexus/StablePay#96 · 1 comment ·
All issues in StabilityNexus/StablePay
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 Under an hour Newbie friendliness 82/100
Leonxlnx/taste-skill#216 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
all-contributors/cli#690 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day