Review unsafe code usage
Maintainers usually reply within 1 day
@marchc1 is already working on this.
Since Oct 6, 2025.
Assessment
This issue has not been assessed yet.
Description
There are a lot of places that use unsafe code right now that really don't need to, especially in the networking code (which was the initial stuff written back in March of this year, before this repo existed).
A good example would be BufferToBufferDecompress (which also should be moved to its own method probably). It just makes spans out of the unsafe pointers. So why aren't we just using spans in everything?
- Dominant language
- C#
- Stars
- 104
- Forks
- 9
- Avg merge
- 8h 52m
- Merged PRs (30d)
- 115
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from SourceDotNET/Source.NET
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
SourceDotNET/Source.NET#203 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
SourceDotNET/Source.NET#210 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
SourceDotNET/Source.NET#117 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
SourceDotNET/Source.NET#116 ·
Maintainers usually reply within 1 day
-
We need to consider a unified API for validationMay be free again @marchc1 claimed this 368 days ago, and no pull request is open. OpenEnhancement Needs More Info
SourceDotNET/Source.NET#37 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
All issues in SourceDotNET/Source.NET
Similar issues
-
Backend enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
UI: money shows the minus sign next to the number, not before the currency (IL -3.0m, not -IL 3.0m)Openarea: sim area: unity enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
eyalgolan/statecraft-israel#1107 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
dimitar-radenkov/Pointframe#271 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
qew21/Genshin-Subtitles#45 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
HoffmanEngineering/3d-print-log-api#274 ·
Maintainers usually reply within 1 day