create-app package needs a little refactoring.

Open
#630 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
cli

Research direction

Start at packages/create-app/src/cli.js around line 252, the link the issue pins, and list the variables that track the same state. The issue does not name them, so first confirm which ones overlap and where each is read and written. Done means one variable holds that state and the CLI still behaves the same, which you can check by running the create-app command. Ask the maintainers which variable they want kept before editing, since the issue leaves that open.

Written by the indexing model from the issue text.

Description

area: developer-experience maintenance priority: P3

https://github.com/SonicJs-Org/sonicjs/blob/2250de9bfe2b0783069c10447e0b12b75c7c3367/packages/create-app/src/cli.js#L252

There are too many variables all tracking the same thing. There should be a single source of truth.

Dominant language
TypeScript
Stars
1.8k
Forks
219
Avg merge
2d 21h
Merged PRs (30d)
67

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SonicJs-Org/sonicjs

All issues in SonicJs-Org/sonicjs

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.