Follow-up: Address CodeRabbit feedback from PR #1146 (E2E infrastructure hardening)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- github-actions, playwright, typescript, yaml
- Domain
- ci-cd, documentation, testing
Research direction
Start with the checklist and read pr-tests.yml around lines 94 and 136 together with global-setup.ts and playwright.config.ts; these are the CI and E2E entry points. Run the E2E workflow or the relevant Playwright command to confirm current behavior before changing guards, secrets or flaky-test settings. Done means each checklist item is addressed, CI is green, and the two documentation edits in docs/testing/e2e-infrastructure-audit.md remove the personal path and stale integration claim.
Written by the indexing model from the issue text.
Description
Context
PR #1146 ("test: harden E2E infrastructure without weakening regression checks") received automated CodeRabbit feedback that was deferred to get CI green and merge the hardening changes.
Items to address
Major (CodeRabbit)
-
pr-tests.yml:94— Verify wrangler.toml binding rewrites (D1database_id/database_name, R2bucket_name, KVid) succeeded after editing; fail the step if a rewrite didn't match -
global-setup.ts:6— ReconsiderCIbypass ofE2E_DISPOSABLE_TARGETguard. Currently needed becausepull_request_targetruns main's workflow YAML which doesn't set the env var. Once the workflow changes land on main, restore the strict guard -
playwright.config.ts:20— Re-enablefailOnFlakyTestsonce flaky tests are stabilized (currently commented out as TODO)
Minor (CodeRabbit)
-
pr-tests.yml:136— Use a cryptographically randomE2E_RUN_KEYmasked in logs, provisioned as a Worker secret via Wrangler instead of--var -
confirmation-dialog.template.ts:117(both copies) — Dialog close fallback (requestAnimationFrame) may race with the 200ms leave transition; listen for nativecloseevent and cancel the fallback -
test-runtime.ts:31— Lock fileENOENTin the catch block should be treated as lost ownership (skiprmSync, back off, retry) rather than propagating -
playwright.config.ts:9— Consider using an explicitE2E_REMOTE_PREVIEWflag instead of inferring remote preview fromBASE_URL
Nitpick (CodeRabbit)
-
docs/testing/e2e-infrastructure-audit.md:108— Replace personal absolute path (/Users/lane/.hermes/...) with a placeholder like<scratch>/sonicjs-e2e-state -
docs/testing/e2e-infrastructure-audit.md:147-150— Update text that says preview wrapper "is not integrated" — it now is deployed and checked by the workflow
Pre-merge checks (CodeRabbit)
- PR description formatting (use repo template headings)
- Docstring coverage at 56% vs 80% threshold — add docstrings to touched functions with cyclomatic complexity ≥ 2
Related
- PR #1146
- Dominant language
- TypeScript
- Stars
- 1.8k
- Forks
- 219
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 67
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from SonicJs-Org/sonicjs
-
bug(admin/users): server error returns bare alert HTML causing black-shape visual artifactPossibly taken @lane711 claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
SonicJs-Org/sonicjs#1211 ·
Maintainers usually reply within 1 day
-
area: api bug priority: P2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
SonicJs-Org/sonicjs#1200 ·
Maintainers usually reply within 1 day
-
ResendProvider cannot send on Workers: unbound `fetch` stored as an instance property throws "Illegal invocation"Possibly taken @lane711 claimed this 23 days ago. Openarea: email bug priority: P1
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SonicJs-Org/sonicjs#1099 ·
Maintainers usually reply within 1 day
-
Email plugin settings are never read: loadDbEmailSettings queries a v2 `plugins` table that does not exist in v3Possibly taken @lane711 claimed this 23 days ago. Openarea: email bug priority: P1
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
SonicJs-Org/sonicjs#1098 ·
Maintainers usually reply within 1 day
-
area: documentation bug documentation priority: P2
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SonicJs-Org/sonicjs#1012 ·
Maintainers usually reply within 1 day
All issues in SonicJs-Org/sonicjs
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
AloisSeckar/elrh-cosca#36 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
cursor/community-plugins#572 ·
Maintainers usually reply within 1 day
-
[Plugin] calendarOpen
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
MUKE-coder/grit#228 ·
-
bug status:needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
dongdongbh/Mindwtr#1587 ·
Maintainers usually reply within 1 day