Initial conditions should have instructions & be selectable for all variables (repost of SimVascular/svZeroDSolver#141)
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- documentation
Research direction
Start with the linked svZeroDSolver issue and the repository's documentation entry points; no specific file or test is named here. Document examples for setting initial conditions, including internal state variables such as Windkessel pressure and chamber states, and clearly identify any variables that cannot be changed.
Written by the indexing model from the issue text.
Description
Problem
The documentation does not make it clear how to set initial conditions. This is especially unclear for internal state variables such as the Windkessel pressure in an RCR bc or the chamber state variables.
This was originally opened in the svZeroDSolver itself. https://github.com/SimVascular/svZeroDSolver/issues/141#issuecomment-3134532653
Solution
The documentation should show examples of setting initial conditions for state variables. The variable "pressure_c:OUTLET" appears to control the windkessel pressure in the RCR.
An example of initial condition block is:
"initial_condition": {
"Vc:ventricle": 69.530841853596712,
"pressure:vessel:OUTLET": 1.333223680000000e+05,
"pressure:INFLOW:valve0": 0.0,
"pressure:valve0:ventricle": 0.0,
"pressure:ventricle:valve1": 0.0,
"pressure:valve1:vessel": 1.333223680000000e+05,
"pressure_c:OUTLET": 1.333223680000000e+05
}
Additional context
It is possible that some of these variables are initialized in some hard coded manner, to zero, estimated steady state only, etc. If this is the case, then code to set initial values for all possible variables should be added and it should be mentioned which state variables cannot be changed.
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
- Dominant language
- HTML
- Stars
- 3
- Forks
- 26
- Avg merge
- 13d 1h
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from SimVascular/simvascular.github.io
-
Add WSL2 guidance for Windows usersMay be free again @ktbolt claimed this 54 days ago, and no pull request is open. Openenhancement
SimVascular/simvascular.github.io#103 · 6 comments · 2 assignees ·
-
Creation of CFD User GuideMay be free again @ktbolt claimed this 83 days ago, and no pull request is open. Opendocumentation
SimVascular/simvascular.github.io#100 · 19 comments · 2 assignees ·
-
Solver documentation needs a working tutorial, updates, and correctionsMay be free again @ryanspilker claimed this 181 days ago, and no pull request is open. Openbug
SimVascular/simvascular.github.io#91 · 11 comments · 1 assignee ·
-
Update svMultiPhysics documentation with Docker image link (simvascular/svmultiphysics)May be free again @ktbolt claimed this 185 days ago, and no pull request is open. Opendocumentation
SimVascular/simvascular.github.io#90 · 2 comments · 1 assignee ·
-
Update coronary documentationMay be free again @menon-karthik claimed this 200 days ago, and no pull request is open. Openenhancement
SimVascular/simvascular.github.io#85 · 5 comments · 3 assignees ·
All issues in SimVascular/simvascular.github.io
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
MicrosoftLearning/PL-400_Microsoft-Power-Platform-Developer#231 ·
-
docs good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
VenetoStato/giorgio#6 ·
-
specification
Difficulty 1/5 Under an hour Newbie friendliness 85/100
WICG/webmonetization#754 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
linagora/twake-on-matrix#3446 ·
Maintainers usually reply within 3 days
-
feature request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 2 days