bug (parser function): `height` in vh breaks the canvas
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- css, javascript
Research direction
The height and width are set in resources/KnowledgeGraph.js around lines 1074-1079, both on the wrapper and on the vis-network options. Start by reading that block to see which value reaches vis-network, then reproduce with a 75vh height on a graph page. Done means the canvas fills the wrapper for vh values, with the wrapper as the only place the size is set, and the existing px and % cases still render.
Written by the indexing model from the issue text.
Description
height is set on the wrapper and also passed to vis-network, which only accepts px and %. With 75vh the wrapper is 75vh, the canvas falls back to 150px and the rest is cut off.
Suggestion: set height/width on the wrapper only, pass 100% to vis-network.
Workaround: .KnowledgeGraph .vis-network { height: 100% !important; }
- Dominant language
- JavaScript
- Stars
- 5
- Forks
- 5
- Avg merge
- 6m
- Merged PRs (30d)
- 4
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from SemanticMediaWiki/KnowledgeGraph
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
SemanticMediaWiki/KnowledgeGraph#107 · 1 comment ·
-
enhancement question
Difficulty 4/5 3-5 days Newbie friendliness 35/100
SemanticMediaWiki/KnowledgeGraph#7 · 4 comments · 1 reaction ·
All issues in SemanticMediaWiki/KnowledgeGraph
Similar issues
-
area:install bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
yetone/magpie#2406 · 1 comment ·
Maintainers usually reply within 1 day
-
[BUG]: Prompt compressor crashes with TypeError when a past chat has a non-string response.textPossibly taken @ManojDevarajulu claimed this today. Openpossible bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Mintplex-Labs/anything-llm#6737 ·
Maintainers usually reply within 1 day
-
check:passed feeds:add
Difficulty 2/5 Under an hour Newbie friendliness 62/100
-
Remove the dead tree 'loadfail' handler in browser.js, which calls a non-existent tree.isSelected()OpenHousekeeping
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pgadmin-org/pgadmin4#10601 ·
Maintainers usually reply within 1 day