Rethink class hierarchy

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp

Research direction

Start by reading the existing ILEFunction and PGMFunction classes, focusing on their resolving and loading responsibilities and how direct program or library loading currently works. Compare those responsibilities with the proposed MIObject, ILEServiceProgram, ILESymbol, and ILEFunction hierarchy. Done means the reusable loading and resolving behavior is separated without breaking the simple direct-loading case.

Written by the indexing model from the issue text.

Description

enhancement

Currently ILEFunction and PGMFunction handle a lot of things like i.e. resolving or loading that could be reused across multiple instan, or split it up to better handle i.e. missing functionality without crashing.

Something like (hierarchy matches how you):

  • MIObject (wrap _RSLOBJ)
    • PGMFunction (wrap _PGMCALL)
    • ILEServiceProgram (wrap _ILELOAD), can be loaded from paths or MIObject
      • ILESymbol (wrap _ILESYM), could be used for either code or data
      • ILEFunction (wrap _ILECALL), could either wrap ILESymbol for code or be distinct _ILESYM caller

You'd want to handle the easy case of loading a program/library directly with these classes still, to avoid boilerplate for the simple case.

Dominant language
C++
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SeidenGroup/pase-cpp

All issues in SeidenGroup/pase-cpp

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.