Follow-ups from the review of #81

Open Beginner friendly
  • Is something wrong?
#83 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Domain
documentation

Research direction

Read step 4 in CONTRIBUTING.md, especially the review procedure for Paul's PRs. State when Codex runs a second time and when the re-review alone checks its fixes, following the rule and example wording in the issue. Done when step 4 clearly covers both cases.

Written by the indexing model from the issue text.

Description

lane:repo
Lane

repo

Requirement IDs

ENG-5

What and why

Follow-ups from the review of #81.

  • CONTRIBUTING.md:99 (step 4 of "How Claude runs the reviews on Paul's PRs"): it says "Codex runs at most twice per PR", but no step says when the second run happens. When Claude's first review has nothing under Must fix, Codex runs in step 2 and its high findings get fixed in step 3. Then nothing says whether Codex checks those fixes. This gap was there before #81 too.

    The rule Claude has followed since 2026-10-16 is that the second Codex run happens only if a high finding needed real code. Writing it down would settle it, for example: "If Codex already ran in step 2 and one of its high findings needed real code, Codex runs again on the fix commit, at the same time as the re-review. Otherwise the re-review alone checks the fixes."

Done when
  • Step 4 in CONTRIBUTING.md says when Codex's second run happens, and when the re-review alone checks Codex's fixes
Notes
  • Docs only. No src/ change, so no Codex review.
  • Small enough to go in the next repo-lane PR rather than its own.
Dominant language
Python
Stars
0
Forks
0
Avg merge
5d 16h
Merged PRs (30d)
4

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SPARDiffData/differential-data-collection

All issues in SPARDiffData/differential-data-collection

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.