Sync status links to a remote record that was deleted when the classification was withdrawn

Open Beginner friendly
#2,672 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
backend

Research direction

Read the sync status link code around ClassificationModificationSyncRecord.remote_url and inspect how it handles the upload response. Check the VG3 SA Path production sync link mentioned in #1347 as well. Treat a response with deleted: True as having no remote URL, and verify that withdrawn classifications no longer show a dead link in the Synced and Excluded states.

Written by the indexing model from the issue text.

Description

🤖 Written by Claude

The sync status on a classification page links to the record on the remote using the pk from the upload response (ClassificationModificationSyncRecord.remote_url). When the upload was the withdrawal of a record the remote held below all users, the remote deletes it and answers with the record's JSON plus deleted: True. That response still carries meta.id, so the page links to a record that no longer exists on the remote.

The withdrawal's sync record is the latest successful one, so a withdrawn classification shows the dead link in the Synced and Excluded states.

Fix: no remote URL for a sync record whose response says deleted.

The same applies to the VG3 SA Path production branch's sync link (#1347).

Dominant language
Python
Stars
31
Forks
4
Avg merge
7h 20m
Merged PRs (30d)
347

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SACGF/variantgrid

All issues in SACGF/variantgrid

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.