C-variadic function definitions are rejected, blocking varargs_without_pattern lint
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by tracing gccrs handling of c_variadic function definitions and compare it with the valid unsafe extern "C" examples in the issue. Use the provided reproducer to verify that supported C-variadic definitions compile and that varargs_without_pattern can be reached; done means the valid forms are no longer rejected outright.
Written by the indexing model from the issue text.
Description
The rustc varargs_without_pattern lint warns when ... is used as a C-variadic argument in a function definition without a pattern name.
gccrs hard-errors on any c_variadic function definition, even the well-formed unsafe extern "C" form:
#![feature(c_variadic)]
pub unsafe extern "C" fn f(args: ...) {}
// gccrs: only foreign or `unsafe extern "C"` functions may be C-variadic
pub unsafe extern "C" fn g(...) {}
// same error
Since the construct cannot be compiled at all, the lint is moot until gccrs supports C-variadic function definitions.
- Dominant language
- C++
- Stars
- 3k
- Forks
- 238
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 31
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rust-GCC/gccrs
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 3 days
-
Allow pattern matching of floating point literalsPossibly taken @Vivekkumar0995 claimed this 7 days ago. Opencleanup good-first-pr typechecking
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Rust-GCC/gccrs#5047 · 3 comments · 1 assignee ·
Maintainers usually reply within 3 days
-
ICE in variance analysis on core, projection field keeps the impl's type paramPossibly taken @u7k4rs6 claimed this 1 day ago. Opentypechecking
Rust-GCC/gccrs#5074 · 1 assignee ·
Maintainers usually reply within 3 days
-
subset-error typechecking
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Maintainers usually reply within 3 days
-
Difficulty 3/5 1-2 days Newbie friendliness 46/100
Rust-GCC/gccrs#5060 · 2 comments ·
Maintainers usually reply within 3 days
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
pocoproject/poco#5664 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
charmplusplus/charm#4210 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
cp-algorithms/cp-algorithms#1748 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day