upgrade: V13-LOCALE-JIFF-DATES and V13-CAPITAL-INVOICE-JIFF-DATE flag code that already uses jiff

Open
#844 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@venelouis is already working on this.

Since Nov 22, 2026.

  • #847 by @venelouis — open

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
32/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
tooling

Research direction

Open pull request #847 first: it already targets these two rules, so read it before touching anything. Then find the rule definitions for V13-LOCALE-JIFF-DATES and V13-CAPITAL-INVOICE-JIFF-DATE in the rules directory and see how each matches call arguments, so jiff value types and jiff::/rullst::orm:: paths can be recognised and skipped. Done means --all-rules no longer reports migrated code and the rule's regression test fixtures cover both a flagged and a silent case.

Written by the indexing model from the issue text.

Description

With --all-rules, both rules report as must-change code that already passes jiff values, so an application that finished the migration still sees required changes.

Fix: recognise jiff arguments (types and jiff::/rullst::orm:: paths) and stay silent, with regression tests.

Reported by the maintainer's applications while upgrading to 13.0.0-alpha.6 and adopting its improvements (21 November 2026).

Dominant language
Rust
Stars
21
Forks
6
Avg merge
5h 35m
Merged PRs (30d)
246

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rullst/Rullst

All issues in Rullst/Rullst

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.