fix(fuselage): `IconButton` `pressed` state is not exposed via `aria-pressed`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
Research direction
Start from the IconButton component in the Fuselage package, where the pressed prop currently only adds the -pressed classes. Find where the element's attributes are set and decide how aria-pressed should be derived from pressed. Done when aria-pressed is set whenever pressed is defined, and a caller that already passes its own aria-pressed is not broken. A test or Storybook story that renders the button with and without pressed should confirm this.
Written by the indexing model from the issue text.
Description
Description
IconButton's pressed prop only adds the -pressed classes. Assistive technology never hears the toggle state unless the caller also passes aria-pressed, and most Rocket.Chat callers do not.
Suggested fix
Set aria-pressed={pressed} when pressed is defined.
Context
Found by cubic while reviewing #42763, which moved @rocket.chat/fuselage into this monorepo. The behavior is unchanged from Fuselage 0.96.0, so it was out of scope there.
- Dominant language
- TypeScript
- Stars
- 46.3k
- Forks
- 14k
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 254
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from RocketChat/Rocket.Chat
-
todo
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
RocketChat/Rocket.Chat#42824 ·
Maintainers usually reply within 1 day
-
fix(fuselage): `EmailInput` lets a spread `type` override `type="email"`Possibly taken @schizophrenicmaniac claimed this today. Openarea: ui/ux type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
RocketChat/Rocket.Chat#42811 · 1 comment ·
Maintainers usually reply within 1 day
-
docs(fuselage): fix rendered class output example in `Box` overviewPossibly taken @ajayg10 claimed this today. Openarea: ui/ux type: chore
Difficulty 1/5 Under an hour Newbie friendliness 85/100
RocketChat/Rocket.Chat#42810 · 2 comments ·
Maintainers usually reply within 1 day
-
area: ui/ux type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
RocketChat/Rocket.Chat#42805 ·
Maintainers usually reply within 1 day
-
fix(fuselage): `CardGrid` renders empty grid items for null or boolean childrenPossibly taken @Aviral-Ranjan claimed this today. Openarea: ui/ux type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
RocketChat/Rocket.Chat#42804 · 1 comment ·
Maintainers usually reply within 1 day
All issues in RocketChat/Rocket.Chat
Similar issues
-
`cf complete zsh >> .zshrc` fails on vanilla zshMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
cloudflare/cf#340 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Rename Madson cameraOpen
Difficulty 2/5 Under an hour Newbie friendliness 75/100
StoDevX/AAO-React-Native#8785 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
bnv-manager-v2: accept_invite creates the Mailcow domain admin before the commitPossibly taken @myOmikron claimed this today. Openbug ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 82/100