Refuse realtime work while close owns the Socket
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- api, networking
Research direction
Read parent issue #412 and blocker #417 first, then trace the Socket and Transport entry points for DDP, Login, Logout, subscription, and Liveness work. Add or extend tests for waiting, queued, already-written, cancellation, settlement, and late-callback cases; done means all listed acceptance criteria pass without obsolete disconnected lifecycle handling.
Written by the indexing model from the issue text.
Description
Parent
#412
What to build
Prevent new DDP, Login, Logout, subscription, and Liveness work from reaching a Transport while close owns the Socket, while preserving the established outcomes of work that was already written.
Acceptance criteria
- New DDP work during close rejects with
[ddp] connection closed before the response arrivedand writes no message. - Work waiting to write, queued work, and already-written work settle according to the ownership decision in #412.
- Liveness work cannot reach the Transport while close owns the Socket.
- Login and Logout requested during close reject before changing Login state, request queues, or DDP subscriptions.
- Existing DDP subscription bookkeeping remains correct across close cancellation and direct wait settlement.
- The obsolete Socket
disconnectedevent no longer drives settlement or appears as a lifecycle event. - Stream-data listeners continue to observe the retained
connecting,close, andconnectedevents. - Tests cover waiting-to-write, queued, already-written, Liveness, Login, Logout, subscription, and late-callback cases.
Blocked by
- #417
- Dominant language
- TypeScript
- Stars
- 146
- Forks
- 101
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from RocketChat/Rocket.Chat.js.SDK
-
refactor: delete the unused replaceLog and silence exports from lib/log.tsPossibly taken @ayushi-wq claimed this 81 days ago. Openbug ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
RocketChat/Rocket.Chat.js.SDK#380 · 1 comment ·
-
refactor: delete the unassigned messages and joinedIds fields on DriverPossibly taken @arbazkhan971 claimed this 68 days ago. Openbug ready-for-agent
Difficulty 1/5 Under an hour Newbie friendliness 90/100
RocketChat/Rocket.Chat.js.SDK#379 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
RocketChat/Rocket.Chat.js.SDK#308 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
RocketChat/Rocket.Chat.js.SDK#306 ·
-
bug
Difficulty 2/5 Half a day Newbie friendliness 78/100
RocketChat/Rocket.Chat.js.SDK#254 ·
All issues in RocketChat/Rocket.Chat.js.SDK
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
langchain-ai/langchainjs#12239 ·
Maintainers usually reply within 1 day
-
Board view: the Monitoring column is always empty because compact issue rows drop displayStatusOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100
paperclipai/paperclip#21837 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
code-yeongyu/senpi#6813 ·
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 93/100
lingdojo/kana-dojo#34169 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100