clients/Rocketchat.ts re-exports nothing: `export *` does not forward a default export
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- tooling
Research direction
Start by checking whether clients/Rocketchat.ts is a supported entry point for the app, then compare it with index.ts and lib/clients/Rocketchat.ts. Decide whether the shim should expose the client or be removed, and verify the chosen behavior with a focused import check since no test currently covers this path.
Written by the indexing model from the issue text.
Description
clients/Rocketchat.ts at the repo root is a one-line deep-import shim:
export * from '../lib/clients/Rocketchat'
lib/clients/Rocketchat.ts declares only a default export:
export default class RocketChatClient extends ClientRest implements ISocket {
export * does not forward a default export, so the shim's export surface is empty. A consumer reaching for the deep path gets nothing:
import Rocketchat from '@rocket.chat/sdk/clients/Rocketchat'—undefinedimport { RocketChatClient } from '@rocket.chat/sdk/clients/Rocketchat'— not exported either
Verified at runtime: importing the shim as a namespace and reading Object.keys returns [].
The root interfaces/index.ts is unaffected — it holds the real declarations rather than re-exporting, and lib/ imports it directly.
index.ts is the working entry point (import Rocketchat from './lib/clients/Rocketchat'), so nothing inside this repo depends on the shim, and no test covers it. Whether the fix is export { default } from '../lib/clients/Rocketchat' or deleting the shim depends on whether the deep path is a supported entry point for the app — that is the call to make first.
- Dominant language
- TypeScript
- Stars
- 146
- Forks
- 101
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from RocketChat/Rocket.Chat.js.SDK
-
refactor: delete the unused replaceLog and silence exports from lib/log.tsPossibly taken @ayushi-wq claimed this 81 days ago. Openbug ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
RocketChat/Rocket.Chat.js.SDK#380 · 1 comment ·
-
refactor: delete the unassigned messages and joinedIds fields on DriverPossibly taken @arbazkhan971 claimed this 68 days ago. Openbug ready-for-agent
Difficulty 1/5 Under an hour Newbie friendliness 90/100
RocketChat/Rocket.Chat.js.SDK#379 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
RocketChat/Rocket.Chat.js.SDK#308 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
RocketChat/Rocket.Chat.js.SDK#306 ·
-
bug
Difficulty 2/5 Half a day Newbie friendliness 78/100
RocketChat/Rocket.Chat.js.SDK#254 ·
All issues in RocketChat/Rocket.Chat.js.SDK
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
langchain-ai/langchainjs#12239 ·
Maintainers usually reply within 1 day
-
Board view: the Monitoring column is always empty because compact issue rows drop displayStatusOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100
paperclipai/paperclip#21837 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
code-yeongyu/senpi#6813 ·
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 93/100
lingdojo/kana-dojo#34169 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100