bug: Reply Button Not Functioning Properly in Chat

Open
#6,193 7 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
react-native, typescript
Domain
mobile-dev

Research direction

No source files or tests are named. Reproduce the reply interaction shown in the screen recording, then trace the chat message and Reply-button entry points to determine which interaction should open the thread and whether the composer should receive focus. Done means the agreed behavior works consistently when opening a thread from a message and from Reply.

Written by the indexing model from the issue text.

Description

Description

When clicking on a chat message, the Reply button does not seem to work. This might be because the entire message is wrapped inside a button/Touchable that opens the thread. While this design makes it easier for users to enter a thread without searching for the reply button, I don't think this was the intended behavior.

Screen Recording

https://github.com/user-attachments/assets/a6c9d369-c93d-48ca-847e-d71d059d5097

Proposed Solutions

We have a few possible ways to address this:

  1. Remove the Reply button altogether if we continue allowing users to open threads by clicking anywhere on the message.
  2. Disable the whole message click and make sure only the Reply button opens the thread.
  3. Reply button opens the thread and focuses on the text input opening the keyboard inside the thread. (Clicking will open it like this )

Please share your thoughts on which approach would be best. I'm happy to discuss further! 🚀

Dominant language
TypeScript
Stars
2.4k
Forks
1.5k
Avg merge
1d 15h
Merged PRs (30d)
29

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RocketChat/Rocket.Chat.ReactNative

All issues in RocketChat/Rocket.Chat.ReactNative

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.