Class hierarchy causes unexpected Typescript error

Open
#125 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
build-system, cli

Research direction

Start with the example repository at https://github.com/GJKrupa/rocketchat-cli-125 and reproduce the issue using rc-apps package; compare that result with a successful npx tsc compile. Investigate the packaging path and class-hierarchy handling, and consider the issue done when the derived class packages without the Class extends value undefined error.

Written by the indexing model from the issue text.

Description

In my app I've included a class hierarchy with a base and a derived class in the same directory (./src). If I attempt to instantiate an instance of the derived class I see the following error when packaging the app:

❯ rc-apps package
packaging your app... !
    TypeError: Class extends value undefined is not a constructor or null

The code is valid and compiles if I use npx tsc.

See https://github.com/GJKrupa/rocketchat-cli-125 for an example

If I remove the call to the derived class constructor or remove the class hierarchy then the error goes away

Dominant language
TypeScript
Stars
49
Forks
40
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RocketChat/Rocket.Chat.Apps-cli

All issues in RocketChat/Rocket.Chat.Apps-cli

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.