docker image of RC 8.4 and 8.5 contains an old incompatible version of Deno

Open
  • Is something wrong?
#290 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
deno, dockerfile
Domain
devops, infrastructure

Research direction

Review pull request #286 in RocketChat/Docker.Official.Image first, then inspect how Deno is selected for RC 8.4 and 8.5 images and how older versions are handled. Done means the official images use the required Deno version without breaking compatibility for RC versions through 8.3.

Written by the indexing model from the issue text.

Description

Docker image contains Deno 1.43.5, which is not the required version of Deno for Rocket.Chat 8.4 and 8.5 (it should be 2.3.1 - see https://github.com/RocketChat/Rocket.Chat/releases/tag/8.4.0)

We noticed the issue after recently upgrading from 7.13 to 8.5. The symptoms were that desktop notifications stopped working for users (at least using the desktop app, don't know about browser), apps would not allow to be enabled anymore and I think some other issues too, but can't remember right now. The mentioned ones were the most pressing.

Our solution was to replace Deno with 2.9.0 (latest) in our deployed image, but this should be fixed at the origin. Deno 2.3.1 also has a few vulnerabilities with a high score, but official images should include what's specified I think.

There is already a pull request fixing this in https://github.com/RocketChat/Docker.Official.Image/pull/286

I don't know if this fixes it properly, I see potential issues with RC <= 8.3 using the older version of Deno, but this HAS to be fixed sooner rather than later as the Docker image is severely broken as it is now.

I can look over that fix and change something if it's currently not fit for merging, please advise.

best regards,
Borut Mrak

Dominant language
Dockerfile
Stars
336
Forks
226
Avg merge
21d 4h
Merged PRs (30d)
1

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RocketChat/Docker.Official.Image

All issues in RocketChat/Docker.Official.Image

Similar issues

More DevOps issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.