Sprite priority bank 0 is set twice at startup
@seven-shades is already working on this.
Since Nov 17, 2026.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 80/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cpp
- Domain
- computer-graphics
Research direction
Start in the VDP2::Initialize implementation and find the two sprite priority bank calls, where the second one incorrectly names SpriteBank::Bank0. Change it to SpriteBank::Bank1, then add a test that starts the library up and reads the SGL register copy extern uint16_t VDP2_PRISA;, expecting 3 in the low byte and 4 in the high byte. Done means bank 0 maps to Layer3 and bank 1 to Layer4, with the new test passing in the project's build/test setup.
Written by the indexing model from the issue text.
Description
- What this is: VDP2::Initialize gives sprite priority banks their default layers. The docs say bank 0 gets Layer3 and bank 1 gets Layer4.
- Problem: Both calls name SpriteBank::Bank0, so bank 0 ends on Layer4 and bank 1 is never set. Layer4 is also the default color condition, so RGB sprites get blended with the layers below whenever sprite color calculation is on. The docs promise they never do.
- Fix: Change the second call to VDP2::SpriteBank::Bank1. Add a test that reads SGL's register copy VDP2_PRISA (extern uint16_t VDP2_PRISA;) after start-up and expects 3 in the low byte and 4 in the high byte.
- If we skip it: Games that turn on sprite color calculation get half-transparent RGB sprites and can't tell why.
- Dominant language
- C++
- Stars
- 90
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ReyeMe/SaturnRingLib
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
ReyeMe/SaturnRingLib#155 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ReyeMe/SaturnRingLib#152 ·
-
SpriteLayer::SetOpacity(1.0) writes ratio -1Possibly taken @seven-shades claimed this today. Openbug required hardware test
Difficulty 1/5 1-3 hours Newbie friendliness 82/100
ReyeMe/SaturnRingLib#151 · 1 assignee ·
-
VDP2::ClearVRAM never frees background-layer palettes (saturnringlib/srl_vdp2.hpp:1912,1924,1935,1946)Possibly taken @seven-shades claimed this today. Openbug required hardware test
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ReyeMe/SaturnRingLib#148 · 1 assignee ·
-
128- and 64-color palettes can share color memory with other palettes (saturnringlib/srl_cram.hpp:173-264)Possibly taken @ReyeMe claimed this today. Openbug required hardware test
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
ReyeMe/SaturnRingLib#147 · 1 assignee ·
All issues in ReyeMe/SaturnRingLib
Similar issues
-
ai_p2
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
ClickHouse/ClickHouse#132519 ·
Maintainers usually reply within 1 day
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeOpen
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
juce-framework/JUCE#1810 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
petercorke/robotics-toolbox-python#952 ·
Maintainers usually reply within 1 day
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusOpenfunc:engine type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
NatronGitHub/Natron#1276 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day