special treatment to stop underlying docker container if running via shim?

Open
#52 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
docker, shell

Research direction

Start by reading the linked datalad-container issue #144 and inspecting containers/scripts/singularity_cmd, then reproduce the shim termination while checking docker ps. Done means the underlying Docker container is stopped when the shim exits or is killed, with the behavior verified using the reported reproduction.

Written by the indexing model from the issue text.

Description

follow up to https://github.com/datalad/datalad-container/issues/144
where I tried just to kill our shim but docker container seems remain running:

(git-annex)lena:~/.tmp/repro-6XkWWkE/ds000003-qc[master]git-annex
$> containers/scripts/singularity_cmd: line 1: warning: wait_for: recursively setting old_sigint_handler to wait_sigint_handler: running_trap = 1

$> kill 3217993
kill: kill 3217993 failed: no such process

$> docker ps
CONTAINER ID        IMAGE                             COMMAND                  CREATED             STATUS              PORTS               NAMES
39e56a15687a        repronim-containers-sing:latest   "/entrypoint.sh run …"   5 minutes ago       Up 5 minutes                            practical_gagarin
Dominant language
Python
Stars
32
Forks
17
Avg merge
12h 2m
Merged PRs (30d)
3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ReproNim/containers

All issues in ReproNim/containers

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.