test() doesn't distinguish plain NA_real_, NaN
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- r
- Domain
- testing-qa
Research direction
Start by reproducing the two examples using the data.table:::test entry point. Inspect how it compares plain NA_real_ and NaN versus list-wrapped values, then add or update coverage so the helper distinguishes them consistently and both examples pass.
Written by the indexing model from the issue text.
Description
# no error
data.table:::test(1, NA_real_, NaN)
# but it's not totally NA-NaN-unaware
data.table:::test(1, list(NA_real_), list(NaN))
# Test 1 ran without errors but failed check that x equals y:
# > x = list(NA_real_)
# First 1 of 1 (type 'list'):
# [[1]]
# [1] NA
# > y = list(NaN)
# First 1 of 1 (type 'list'):
# [[1]]
# [1] NaN
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one)Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 70/100
Rdatatable/data.table#7903 ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 95/100
tidymodels/textrecipes#332 ·
-
benchmark bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 Half a day Newbie friendliness 78/100
ThinkR-open/datadiff#59 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day