Bug in UVCal read of FHD calibration data?
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start in pyuvdata/uvcal/fhd_cal.py where gain_array is built, and compare it with the read-in conjugation applied in pyuvdata/uvdata/fhd.py. Then trace utils.uvcalibrate to see how flip_gain_conj is applied when forming g_1 g_2^* versus g_1^* g_2. Check existing FHD calibration tests and add a case that compares calibrated visibilities with model visibilities; done means the gain convention matches FHD and the test pins it down.
Written by the indexing model from the issue text.
Description
In uvdata.fhd the visibilities are conjugated on read-in to create the data_array because the FHD convention is supposed to be flipped. However a similar conjugation doesn’t happen in uvcal.fhd_cal on creating the gain_array. So $v_{ij}$ seems to be conjugated for FHD but not $g_{ij}$.
I guess because of that, when applying utils.uvcalibrate with a UVCal object created from a calh5 file converted with UVCal from the original FHD files, I get a better result if I set flip_gain_conj=True than if I don’t, i.e. if the calibration is applied with $g_1^* g_2$ instead of $g_1 g_2^*$. (By “better result” I mean I see a smaller magnitude difference between the calibrated visibilities and the model visibilities.)
It may be worth mentioning that FHD (in FHD/fhd_core/calibration/vis_calibration_apply.pro) currently follows the conjugation convention $g_1 g_2^*$ for the gains on antennas 1 and 2 — the opposite of the convention set by flip_gain_conj=True.
- Dominant language
- Python
- Stars
- 103
- Forks
- 40
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 13
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from RadioAstronomySoftwareGroup/pyuvdata
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
RadioAstronomySoftwareGroup/pyuvdata#1751 ·
Maintainers usually reply within 3 days
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
RadioAstronomySoftwareGroup/pyuvdata#1750 ·
Maintainers usually reply within 3 days
-
Difficulty 3/5 Half a day Newbie friendliness 48/100
RadioAstronomySoftwareGroup/pyuvdata#1749 ·
Maintainers usually reply within 3 days
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
RadioAstronomySoftwareGroup/pyuvdata#1743 ·
Maintainers usually reply within 3 days
-
Unpin Python 3.15Opencontinuous_integration technical debt
Difficulty 2/5 Under an hour Newbie friendliness 18/100
RadioAstronomySoftwareGroup/pyuvdata#1742 ·
Maintainers usually reply within 3 days
All issues in RadioAstronomySoftwareGroup/pyuvdata
Similar issues
-
author-page correction move-papers
Difficulty 1/5 Under an hour Newbie friendliness 78/100
acl-org/acl-anthology#10978 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
GoogleCloudPlatform/professional-services-data-validator#1899 ·
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
HKUDS/CLI-Anything#652 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Project-N-E-K-O/N.E.K.O#3813 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Dao-AILab/flash-attention#3191 ·
Maintainers usually reply within 4 days