ui(dialogs): make destructive query and DML preview dialogs adaptive and prevent table name overflow
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
Research direction
Read lib/features/workspace/destructive_query_dialog.dart and lib/features/workspace/dml_preview_dialog.dart, then check how WindowLayout.dialogConstraints(context) and WindowLayout.dialogSymmetricInsets(context) are used elsewhere. Update the dialog sizing and constrain the DML preview table name as described; done means both dialogs fit compact or scaled windows and long table names no longer overflow.
Written by the indexing model from the issue text.
Description
Problem
-
Non-adaptive dialog constraints:
Inlib/features/workspace/destructive_query_dialog.dart, the dialog card uses hardcoded fixed constraints:constraints: const material.BoxConstraints( minWidth: 540, maxWidth: 680, minHeight: 440, maxHeight: 580, ), child: material.FocusTraversalGroup( child: material.SizedBox(height: 540, ...),It does not use
WindowLayout.dialogConstraints(context)orWindowLayout.dialogSymmetricInsets(context). When running on compact window widths (e.g. 520px) or with a UI scale of 1.25x+, the dialog overflows screen bounds. -
Unconstrained table name in DML Preview:
Inlib/features/workspace/dml_preview_dialog.dart, the header row displaysText('${widget.plan.schema}.${widget.plan.tableName}')withoutFlexibleand withoutoverflow: TextOverflow.ellipsis. For long table names, it causes horizontalRenderFlex overflow.
Change
- Migrate
destructive_query_dialog.dartto useWindowLayout.dialogConstraints(context)andWindowLayout.dialogSymmetricInsets(context). - Wrap the table name in
dml_preview_dialog.dartwithFlexible(child: Text(..., overflow: TextOverflow.ellipsis)).
- Dominant language
- Dart
- Stars
- 23
- Forks
- 1
- Avg merge
- 49m
- Merged PRs (30d)
- 496
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from QueryaHub/Querya-Desktop
-
bug P3 ux
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
QueryaHub/Querya-Desktop#1837 ·
Maintainers usually reply within 1 day
-
enhancement P3
Difficulty 4/5 3-5 days Newbie friendliness 50/100
QueryaHub/Querya-Desktop#1838 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 45/100
QueryaHub/Querya-Desktop#1690 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 1-2 days Newbie friendliness 55/100
QueryaHub/Querya-Desktop#1683 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 20/100
QueryaHub/Querya-Desktop#1625 · 2 comments ·
Maintainers usually reply within 1 day
All issues in QueryaHub/Querya-Desktop
Similar issues
-
@apps/catalog enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
ymm-oss/flutter-mobile-project-template#699 ·
Maintainers usually reply within 15 days
-
area::build area::tests
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
linagora/twake-on-matrix#3504 · 1 comment ·
Maintainers usually reply within 3 days
-
[Packages] [flutter_shaders] InkWell shader golden test fails on Flutter stable and Master channelsOpenfrom: manual-qa
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
espresso3389/pdfrx#777 ·
Maintainers usually reply within 4 days
-
README highlightsOpendocumentation
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
patarapolw/lingua_srs#22 ·