extensions: implement operator > on HostVersion
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
Research direction
Read lib/core/extensions/harness/extension_protocol_profile.dart for the HostVersion comparison operators, then inspect _comparatorAllows in extension_manifest_validator.dart. Implement the missing greater-than operator using compareTo; done means HostVersion supports > and the validator can use that comparison directly.
Written by the indexing model from the issue text.
Description
Context
In #1630, HostVersion (lib/core/extensions/harness/extension_protocol_profile.dart) implemented operator <=:
bool operator >=(HostVersion other) => compareTo(other) >= 0;
bool operator <(HostVersion other) => compareTo(other) < 0;
bool operator <=(HostVersion other) => compareTo(other) <= 0;
However, operator > is not implemented on the class. Consequently, _comparatorAllows in extension_manifest_validator.dart evaluates > via the inverted comparison !(host <= HostVersion.parse(...)):
if (c.startsWith('>')) return !(host <= HostVersion.parse(c.substring(1)));
Change
Implement bool operator >(HostVersion other) => compareTo(other) > 0; on HostVersion to complete its comparison operator contract and simplify call sites.
- Dominant language
- Dart
- Stars
- 23
- Forks
- 1
- Avg merge
- 49m
- Merged PRs (30d)
- 496
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from QueryaHub/Querya-Desktop
-
bug P3 ux
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
QueryaHub/Querya-Desktop#1837 ·
Maintainers usually reply within 1 day
-
enhancement P3
Difficulty 4/5 3-5 days Newbie friendliness 50/100
QueryaHub/Querya-Desktop#1838 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 45/100
QueryaHub/Querya-Desktop#1690 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 1-2 days Newbie friendliness 55/100
QueryaHub/Querya-Desktop#1683 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 20/100
QueryaHub/Querya-Desktop#1625 · 2 comments ·
Maintainers usually reply within 1 day
All issues in QueryaHub/Querya-Desktop
Similar issues
-
good first issue help wanted translation
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
blankframe-tech/ThrottleIQ#23 ·
Maintainers usually reply within 5 days
-
good first issue mobile P0 size:S
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
trufi-association/trufi-core#1024 ·
Maintainers usually reply within 14 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
-
@apps/catalog enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
ymm-oss/flutter-mobile-project-template#699 ·
Maintainers usually reply within 15 days