Emptying the Recycle Bin stops when the preview window is closed
Maintainers usually reply within 4 days
Nobody has claimed this yet.
- #2069 by @mohamadsm313m-prog — closed without merging
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 57/100
Research direction
Start at the Recycle Bin preview button that calls SHEmptyRecycleBin in the QuickLook viewer process, and trace how that operation is launched. The issue proposes a detached QuickLook.exe --empty-recycle-bin helper; check how command-line arguments are handled. Done means emptying continues after the preview closes or another file is previewed, without blocking the viewer.
Written by the indexing model from the issue text.
Description
Description
When the Recycle Bin is previewed, the "Empty Recycle Bin" button runs SHEmptyRecycleBin inside the QuickLook viewer process. Because the preview is unloaded whenever the window closes or another file is previewed, the deletion is aborted in those cases. The operation also runs on the UI thread, so the viewer stops responding until the deletion finishes.
Steps to reproduce
- Open the Recycle Bin in Explorer (with some files in it).
- Press Space to preview it with QuickLook and press the "Empty Recycle Bin" button, then confirm.
- Immediately close the preview window, or press Space on another file in Explorer.
- The Recycle Bin is not emptied (or only partially emptied).
Expected behavior
The deletion should keep running in the background, independent of the preview window, until the Recycle Bin is empty.
Environment
- QuickLook 4.5.0
- Windows 11 (10.0.26100)
Proposed fix
Run the emptying in a detached QuickLook.exe --empty-recycle-bin helper process (see the linked pull request).
- Dominant language
- C#
- Stars
- 25.7k
- Forks
- 1.4k
- Avg merge
- 3d 19h
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from QL-Win/QuickLook
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 4 days
-
[MarkdownViewer] Mermaid classDiagram with <<annotation>> fails with "Syntax error in text"Possibly taken @suhyun-nam claimed this 11 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
QL-Win/QuickLook#2028 · 3 comments ·
Maintainers usually reply within 4 days
-
[Bug] If the first character entered into the search box is a space, the preview window will close.Possibly taken @MORTEM3845 claimed this 25 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 57/100
Maintainers usually reply within 4 days
All issues in QL-Win/QuickLook
Similar issues
-
Support Flux ignore rules (drift detection ignore paths) in Microsoft.KubernetesConfiguration schemaOpen
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Azure/azure-resource-manager-schemas#3921 ·
Maintainers usually reply within 1 day
-
text-align: justify is ignored in HTML to PDF conversionPossibly taken @PrzemyslawKlys claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area/backend type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
umbraco/Umbraco-CMS#24668 · 1 comment ·
Maintainers usually reply within 1 day