Quicklook ist opened on space bar press even if no file is selected

Open
#2,029 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 4 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
56/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
desktop

Research direction

Start by tracing how QuickLook handles the Space key and determines whether a file is selected, then compare that with Windows Explorer's selection behavior in the reported directory-navigation steps. The issue names no files or tests, so first locate the relevant keyboard-input handling and its tests. Done means pressing Space when no file is selected selects it without opening QuickLook, while the existing open behavior still works for a selected file.

Written by the indexing model from the issue text.

Description

Describe the bug
If you press the spacebar in Windows Explorer when no file is selected it selects the file and opens Quicklook, but should only select the file.

To Reproduce
Open an explorer window and got o any directory which has subdirectories. Enter any subdirectory by pressing enter. Now the first file of the directory shown has a border around, but the file is not selected! You usually have to press the Spacebar to select that file. That however opens Quicklook which it should not in this case, since I only wanted to select the file, not to open Quicklook.

Expected behavior
Do not open Quicklook if no file is selected.
I however acknowledge, that since Quicklook intercepts the Spacebar the "Spacebar pressed" information might come too late to Quicklook when the file is already selected by the explorer?

It might help to allow for configuration of the key pressed to open Quicklook.

Dominant language
C#
Stars
25.8k
Forks
1.4k
Avg merge
3d 19h
Merged PRs (30d)
3

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from QL-Win/QuickLook

All issues in QL-Win/QuickLook

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.