Simplify doble mock in helper tests
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- python
- Domain
- testing-qa
Research direction
Start in test_helpers.py and inspect the tests that use double mocks to simulate downloading scripts. Compare the repeated setup and determine whether a shared self._mock_urlopen-style helper covers those cases. Done means the duplicated mocking is simplified without changing test behavior; run the helper tests to verify them.
Written by the indexing model from the issue text.
Description
There are several tests in test_helpers.py that uses a double mock to mimick hitting the web to download scripts.
It's kind of cumbersome, it could be simplified to a self._mock_urlopen helper or something
- Dominant language
- Python
- Stars
- 223
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PyAr/fades
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
-
Difficulty 5/5 Over a week Newbie friendliness 42/100
-
Revisit "nested virtualenvs" problemPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 30/100
-
PEP 723 supportOpenenhancement
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Similar issues
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
debpalash/VoiceStudio#2624 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
SQLGlot translates Spark concat_ws on an array into array stringificationPossibly taken @ansh-rohilla claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Make Catch2 optional when `RDK_BUILD_CPP_TESTS=OFF`Possibly taken @pechersky claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 2 days