Provenance: `sanitizeJSON` cuts lines at `//` inside strings
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Read AGENTS.md, then inspect sanitizeJSON in DeltaSkins/Models/DeltaSkin.swift and find the existing tests for skin decoding. Start by checking how comment removal handles quoted strings. Add coverage for an info.json URL value and confirm the skin decodes.
Written by the indexing model from the issue text.
Description
Where: Provenance DeltaSkins/Models/DeltaSkin.swift sanitizeJSON
Do:
It strips everything after // on any line, so an info.json value containing a URL breaks decoding. Only strip comments outside strings (or rely on JSONSerialization, which already parses the file first).
Depends on: nothing
Done when: A skin whose info.json has a URL value decodes; covered by a test.
See AGENTS.md before starting.
- Dominant language
- Swift
- Stars
- 0
- Forks
- 0
- Avg merge
- 2h 38m
- Merged PRs (30d)
- 15
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Provenance-Emu/SkinKit
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
Provenance-Emu/SkinKit#34 ·
Maintainers usually reply within 1 day
-
needs-design
Difficulty 5/5 Over a week Newbie friendliness 25/100
Provenance-Emu/SkinKit#26 ·
Maintainers usually reply within 1 day
-
area:skinkit needs-design
Difficulty 5/5 Over a week Newbie friendliness 35/100
Provenance-Emu/SkinKit#25 ·
Maintainers usually reply within 1 day
-
area:icube area:skinkit
Difficulty 5/5 Over a week Newbie friendliness 35/100
Provenance-Emu/SkinKit#24 ·
Maintainers usually reply within 1 day
-
area:website
Difficulty 3/5 1-2 days Newbie friendliness 58/100
Provenance-Emu/SkinKit#23 ·
Maintainers usually reply within 1 day
All issues in Provenance-Emu/SkinKit
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
lognorman20/monaco#7428 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
🎉 Add BossanovaOpen
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
jaywcjlove/awesome-mac#4096 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
amantus-ai/vibetunnel#774 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day