Remove redundant ways to load environment variables
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start by comparing backend/app/core/config.py around the settings definition with backend/app/load_env.py, then search the repository for references to load_env.py. Remove the redundant loader and its calling code while retaining the config.py settings path. Done means no remaining references to load_env.py and environment variables use the single intended approach.
Written by the indexing model from the issue text.
Description
Which feature or component needs enhancement?
The way we manage environment variables in the project
Describe the current behavior
We seem to have two redundant approaches to loading environment variables from the *.env files.
https://github.com/ProjectTech4DevAI/kaapi-guardrails/blob/1d62fc24821ca6e7b5c7d8aeb473fc9052787a4d/backend/app/core/config.py#L94
and
https://github.com/ProjectTech4DevAI/kaapi-guardrails/blob/1d62fc24821ca6e7b5c7d8aeb473fc9052787a4d/backend/app/load_env.py#L5
Describe the enhancement you'd like
The settings variable exposed in config.py seems to be the one we are relying heavily on throughout the codebase. So we can remove the load_env.py and all calling code referencing that file.
Why is this enhancement needed?
This will prevent confusing overrides of environment variables due to the two approaches interacting in unexpected manner.
- Dominant language
- Python
- Stars
- 5
- Forks
- 4
- Avg merge
- 11d 19h
- Merged PRs (30d)
- 1
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ProjectTech4DevAI/kaapi-guardrails
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
-
Callback Enhancement: Include intermediate responsesPossibly taken @Prajna1999 claimed this 26 days ago. Open
ProjectTech4DevAI/kaapi-guardrails#158 · 1 assignee ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
All issues in ProjectTech4DevAI/kaapi-guardrails
Similar issues
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
debpalash/VoiceStudio#2624 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Make Catch2 optional when `RDK_BUILD_CPP_TESTS=OFF`Possibly taken @pechersky claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 2 days
-
There are a few redundant calls to `fdesc._setCloseOnExec()`Possibly taken @gudnimg claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day