`:AddText()`s and `AddTitle()`s don't trigger reflows on deletion
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
Research direction
Start by locating the AddTitle and AddText implementations and their Destroy paths, then compare them with other AddFoo components that already recompute layout on destruction. Reproduce with the provided panel snippet and check where the container layout is invalidated or reflowed. Done means destroying a title or text before adding a button leaves no tall margin and the panel layout recomputes correctly.
Written by the indexing model from the issue text.
Description
Unlike all other items returned from :AddFoo(), these don't recompute the container's layout when :Destroy()ed.
e.g. Pick a panel or something and do the following:
local title = panel:AddTitle("Hello")
title:Destroy()
panel:AddSimpleButton("there")
The button will have what looks like a very tall margin above it.
- Dominant language
- Lua
- Stars
- 6
- Forks
- 4
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 18
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PrettyRS/prettyui
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
PrettyRS/prettyui#15 · 4 comments ·
Maintainers usually reply within 1 day
All issues in PrettyRS/prettyui
Similar issues
-
bug(bufdelete): all()/other() abort with "Invalid buffer id" when a buffer is wiped during the loopOpen
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
folke/snacks.nvim#2986 ·
-
bug discord guide:ruins-of-lordaeron locale:enUS triage v0.3.2
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
fitzforge/polestar#999 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
-
feature request
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100