Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Run the Tests workflow for pull requests into any base branch

Closed
  • Is something wrong?
#1,321 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

  • #1322 by @anth-volk — closed without merging

Assessment

Difficulty
1/5
Estimated time
1-3 hours
Newbie friendliness
25/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
github-actions, python
Domain
ci-cd

Research direction

Read .github/workflows/test.yml and find the test that reads this workflow. Confirm the push trigger remains limited to main, while pull_request has no base branch filter. The issue reports an open linked pull request (#1322), so check its status before starting; done means the workflow and its test cover both trigger settings.

Written by the indexing model from the issue text.

Description

Problem

.github/workflows/test.yml runs for pull_request events only when the pull request's base branch is main:

on:
  push:
    branches: [main]
  pull_request:
    branches: [main]

A stacked pull request targets another pull request's branch rather than main. GitHub therefore starts no Tests run for it: lint, engine-free, the country engine jobs, integration-uk and wheels are all skipped, and the pull request shows no checks at all.

We want to stack microcosm#1295, #1297, #1296 and #1298, which build on each other's changes. Without this change, only the bottom pull request of the stack would get CI.

Proposed change

  • Remove the branches filter from the pull_request trigger, so a pull request into any base branch runs the same jobs.
  • Leave the push trigger at branches: [main].
  • Add a test that reads the workflow and checks both triggers.

What else in the workflow depends on the base branch

Nothing:

  • the concurrency group is keyed on the pull request number;
  • country selection (tools/ci_test_plan.py select-countries) reads the pull request's own changed files from the GitHub API;
  • the workflow never reads github.base_ref;
  • it has no path filters.

Pull requests from branches in this repository get the same GITHUB_TOKEN permissions and the same secrets whatever their base branch. Pull requests from forks get no secrets either way.

Dominant language
Python
Stars
0
Forks
6
Avg merge
1d 8h
Merged PRs (30d)
140

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PolicyEngine/microcosm

All issues in PolicyEngine/microcosm

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.