Missing Shaking Encounters in XY/SM/USUM & Name issue in SM/USUM
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 50/100
Research direction
Start by auditing the API's encounter data for XY, SM, and USUM against the Bulbapedia ambush encounter information linked in the issue. Check existing Chansey, Cottonee, Alolan Rattata, Wimpod, and related encounter methods, then verify that missing methods and names are consistently represented. Done means the affected encounter data is complete and correctly named across these games.
Written by the indexing model from the issue text.
Description
All of these encounter types are missing from XY in the API:
This is important because many pokemon are exclusively encountered this way.
I would model these by adding multiple new encounter methods. Bulbapedia lists these all as "ambush encounter", but then sub-divides them into types. I would only name them after the sub-divided types. This would be:
- Shaking Berry Tree
- Shaking Trash Can
- Bush Ambush
- Drop from Cave Ceiling
- Moving Dust Cloud (Bulbapedia has this as leaping out of ground, but it's not descriptive enough imo)
- Sky Ambush
Some of these encounters are modeled for Gen 7. For example, Chansey is included in USUM. However, for some reason, this is listed as "Bubble Spot", which is the Gen 5 water bubble spot. The rest of the encounter data for it is fine.
That being said, we are still missing some gen 7 encounters like this.
I would rename chansey/cottonees method to:
- Bush Ambush (previously described in my XY section)
A lot of these encounters appear to be in the API, but some are missing.
I couldn't find the one for Rattata Alola in SM Route 2, for example. So I'll have to go in detail and double check everything.
That being said, I think SM/USUMs ambush types mostly have crossover with XY. The only new methods I could see to add are:
- Sand Clouds (beach? Maybe combine with dust clouds)
- Rustling Trees (I think keep separate from the berry tree one, as that's a distinct thing in XY)
- Wimpod Chase (Wimpod is currently listed as "only one" which is really not correct.)
- Water Splash (Could actually use bubbling spot from BW)
- Invisible Kecleon Spots
As usual, I wouldn't bring something up without being willing to take it on myself, but I hope someone else is interested as well.
- Dominant language
- Python
- Stars
- 5.4k
- Forks
- 1.2k
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 18
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PokeAPI/pokeapi
-
Difficulty 2/5 1-2 days Newbie friendliness 76/100
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
UV hardlink files Open
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
Ball legality Open
Difficulty 5/5 Over a week Newbie friendliness 35/100
Similar issues
-
agent-ready documentation needs-triage
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 91/100
-
workflow-status page template still says reusable workflows are "triggered only by workflow_call:" Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
instance instance add
Difficulty 1/5 Under an hour Newbie friendliness 72/100
searxng/searx-instances#939 · 1 comment ·
-
area-deployment area-integrations triage:bot-seen
Difficulty 2/5 Half a day Newbie friendliness 86/100