Blank past ability entries
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 76/100
Research direction
Start with data/v2/csv/pokemon_abilities_past.csv and compare the affected rows with the response from the Pokémon endpoint. Review commit b23cd6fb3049eb493f64b4cd9de05cbeea8d93d9 to understand why blank ability entries were added. Done means affected Pokémon no longer expose past ability records whose ability is null, while preserving valid historical entries.
Written by the indexing model from the issue text.
Description
The past_abilites field in pokemon endpoint has some redundant data which points to no actual ability for example for bulbasaur (1)
"past_abilities": [
{
"abilities": [
{
"ability": null,
"is_hidden": true,
"slot": 3
}
],
"generation": {
"name": "generation-iv",
"url": "https://pokeapi.co/api/v2/generation/4/"
}
}
]
imo either it should point to an ability resource or the past_abilities array should be empty also idt bulbasaur got any change of abilities and this issue is across a bunch of pokemon where the ability_id is blank in here https://github.com/PokeAPI/pokeapi/blob/master/data/v2/csv/pokemon_abilities_past.csv which is causing this
think historically it got added somewhere around here in this commit https://github.com/PokeAPI/pokeapi/commit/b23cd6fb3049eb493f64b4cd9de05cbeea8d93d9 removing the rows with blank entries should fix it
just wanted to ask tho was there any reason why it was added that I might be missing? thank you :)
cc: @jemarq04
- Dominant language
- Python
- Stars
- 5.4k
- Forks
- 1.2k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 18
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PokeAPI/pokeapi
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PokeAPI/pokeapi#1684 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
PokeAPI/pokeapi#1623 · 3 comments ·
Maintainers usually reply within 1 day
-
UV hardlink filesOpen
Difficulty 3/5 1-2 days Newbie friendliness 48/100
PokeAPI/pokeapi#1622 · 3 comments ·
Maintainers usually reply within 1 day
-
Ball legalityOpen
Difficulty 5/5 Over a week Newbie friendliness 35/100
PokeAPI/pokeapi#1612 · 2 comments ·
Maintainers usually reply within 1 day
Similar issues
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
kristofdegrave/homeassistant-smart-charging#1413 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
nasa/earthdata-varinfo#113 ·
-
curriculum documentation quality
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
githubnext/gh-aw-workshop#3849 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day