Article comments: the reply form and buttons are children of the <ul> of comments

Open
  • Is something wrong?
#696 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@guidol-ive is already working on this.

Since Oct 29, 2026.

  • #700 by @guidol-ive — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
25/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
html, javascript, php
Domain
accessibility, frontend

Research direction

Start with peer_reviewed_article::buildDiscussionsHtml() and trace how it builds the discussion wrapper, comment list, reply form, and action button. Move the form and buttons to the wrapper after the list, then check rendered public comments and review discussions to confirm the <ul> contains only <li> elements; linked pull request #700 is already open.

Written by the indexing model from the issue text.

Description

Component: User interface Impact: Low Level: Easy Pagetype: Peer reviewed article Type: Bug Value: Visitors

The comments under an article are a <ul> with one <li> per comment. The form to reply, the button to send it, and in a review the button to close the discussion, are appended to that same <ul>:

<div class="public-comment-wrapper collapsed"><ul>
  <li class="first-comment">…</li>
  <form …>…</form>
  <a class="button" …>Reageer</a>
</ul></div>

A <ul> may only hold <li> (and script-supporting elements). Screen readers announce the list with a wrong number of items, and axe reports list (WCAG 1.3.1).

On a test copy of a site, axe found it on every page with public comments, about 950 pages.

peer_reviewed_article::buildDiscussionsHtml() (the part that renders each discussion) calls $commentList->createChild('p'), $replyForm->appendTo($commentList) and $commentList->appendChild($this->makeDiscussionActionButton(…)).

Fix: append these to the wrapper <div> of the discussion, after the list. No script depends on the form being inside the list; the stylesheet of the default theme only styles ul and li inside the wrapper.

🤖 Generated with Claude Code

Dominant language
JavaScript
Stars
5
Forks
9
Avg merge
18h 49m
Merged PRs (30d)
13

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PlanBCode/hypha

All issues in PlanBCode/hypha

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.