Article: the heading of the comments comes after the comments and the form

Open
  • Is something wrong?
#628 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@guidol-ive is already working on this.

Since Oct 28, 2026.

  • #630 by @guidol-ive — open

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
1/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
php
Domain
frontend

Research direction

Read system/datatypes/peer_reviewed_article.php and inspect createDiscussionsDomElement(), especially where it appends the art-comments and art-review-comments headings. Move the heading before the comment list, as described in the issue; done means both headings appear before their lists and forms. Pull request #630 is already open against this issue.

Written by the indexing model from the issue text.

Description

Component: User interface Impact: Low Level: Easy Pagetype: Peer reviewed article Type: Bug Value: Visitors

On a published article the heading Reacties (art-comments) comes after the comments, after the comment form and after the button, at the very end of the comments block. Without comments, the list item "nog geen reacties" therefore sits directly under the sources, as if it were one of them, and the heading follows below the form. The same happens to the heading Reacties van reviewers (art-review-comments) during the review.

Place. system/datatypes/peer_reviewed_article.php, createDiscussionsDomElement() (main a019475, lines 1640-1641): the <h2> is added with appendHtml() as the last step, after the list and the form.

Since when. Hypha 2018 (1fbcb5e) appended the heading first. The cleanup of 06584a6 (2019) moved it to the end of the function, and d333a73 (2025) kept that order when it replaced append() by appendHtml().

Evidence. Seen on a published article of the fictional test site, as a visitor, on an iPhone (iOS 27, Safari), on Android 15 (Chrome) and on the desktop, PHP 8.2 and 8.5:

<div class="sources"><h2>bronnen</h2>…</div>
<div class="public-comments-wrapper"><ul><li>nog geen reacties</li></ul> … <form …> … <h2>reacties</h2></div>

Fix. Add the heading at the start of createDiscussionsDomElement(), before the list. A pull request follows.

Found while building the Markdown editor (#520).

🤖 Generated with Claude Code

Dominant language
JavaScript
Stars
5
Forks
9
Avg merge
18h 49m
Merged PRs (30d)
13

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PlanBCode/hypha

All issues in PlanBCode/hypha

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.