Windows sandbox: share one drive letter per project and drop the separate temp drive
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 18/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- rust, typescript
- Domain
- operating-systems, security
Research direction
Start in native/sandbox-helper/src/win.rs, where record.project_drive and record.toolchain_drive are assigned, and in ProjectDrive::create(temporary) to see how each run gets its own letter. Then read the recovery journal code that stores letter and target, and the DDD_EXACT_MATCH_ON_REMOVE removal path. Done means concurrent background commands in one project all run when they outnumber free letters, and forced-termination recovery still removes only abandoned mappings. Confirm with the real-helper test the issue asks for.
Written by the indexing model from the issue text.
Description
Follow-up to #177.
#177's fix widened the letter range for sandbox drives from P:–Z: to D:–Z:, and made the error say how many Patch commands hold letters. Each run still holds its own letters for its whole life, background commands included:
- a project drive (
record.project_drive,native/sandbox-helper/src/win.rs), - a temporary drive (
ProjectDrive::create(temporary)), - a toolchain drive when toolchains are staged (
record.toolchain_drive).
With a few user mappings in D:–Z:, roughly eight to ten concurrent commands still use them all up, and each mapping still shows up as an extra drive in Explorer while it exists.
Proposal
- Share one project-drive mapping per project, reference-counted through the recovery journal: recovery records already store the exact letter and target, so a new run in the same project can reuse a live mapping and only the last run removes it.
- Put the temporary folder under the project or toolchain drive instead of giving it its own letter, or reach it by its real path with only its own grant.
- Keep the exact-match removal (
DDD_EXACT_MATCH_ON_REMOVE) so a reused letter is never removed under another run.
Acceptance checks
- A real-helper test starts more concurrent background commands in one project than there are free letters and all of them run.
- Forced-termination recovery still removes only abandoned mappings.
- Dominant language
- TypeScript
- Stars
- 2
- Forks
- 2
- Avg merge
- 5h 28m
- Merged PRs (30d)
- 24
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PierrunoYT/patch
-
enhancement priority: low security severity: low
Difficulty 4/5 3-5 days Newbie friendliness 30/100
PierrunoYT/patch#263 ·
Maintainers usually reply within 1 day
-
enhancement priority: medium security severity: low
Difficulty 5/5 Over a week Newbie friendliness 12/100
PierrunoYT/patch#262 ·
Maintainers usually reply within 1 day
-
platform: macos priority: medium security severity: low tests
Difficulty 4/5 3-5 days Newbie friendliness 15/100
PierrunoYT/patch#257 ·
Maintainers usually reply within 1 day
-
bug platform: macos priority: medium security severity: high
Difficulty 3/5 1-2 days Newbie friendliness 35/100
PierrunoYT/patch#232 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement platform: windows priority: medium security severity: low
Difficulty 5/5 Over a week Newbie friendliness 14/100
PierrunoYT/patch#227 · 1 comment ·
Maintainers usually reply within 1 day
All issues in PierrunoYT/patch
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
JoviDeCroock/pracht#432 ·
Maintainers usually reply within 1 day
-
approved check:passed streams:add
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Hardware attribute name "app Connection Support" has inconsistent casingPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
walletbeat/walletbeat#1628 ·
Maintainers usually reply within 1 day
-
bug go
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
genkit-ai/genkit#6761 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
NousResearch/hermes-agent#136483 ·
Maintainers usually reply within 1 day