URLSearchParams.prototype differs from node: enumerability, key order, extra toLocaleString/valueOf, missing Symbol.iterator
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 56/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- javascript, rust
Research direction
The issue names URLSearchParams.prototype and specifies a gap test comparing getOwnPropertyNames, Reflect.ownKeys, and descriptors with Node. Start by reading the stream/events prototype work in #12708 and the code reached from #12722, then locate URLSearchParams and its tests. Done means the prototype layout matches Node for the listed keys, order, enumerability, and descriptors.
Written by the indexing model from the issue text.
Description
Found during #12722.
perry's URLSearchParams.prototype:
- makes the methods non-enumerable, while node's are enumerable (for-in on an instance lists them in node);
- uses a different own-key order;
- has extra own toLocaleString/valueOf copies;
- lacks Symbol.iterator (and the util.inspect.custom entry).
Fix: a node-exact sealed static prototype layout, like the stream/events prototypes in #12708. Needs a gap test that compares getOwnPropertyNames, Reflect.ownKeys and descriptors with node.
- Dominant language
- Rust
- Stars
- 4.9k
- Forks
- 166
- Avg merge
- 3h 23m
- Merged PRs (30d)
- 911
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PerryTS/perry
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 76/100
Maintainers usually reply within 1 day
Similar issues
-
area:desktop priority:p2 type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
fritzprix/libr-agent#2165 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area:ecosystem bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Chelis-Lang/chelis#3942 ·
Maintainers usually reply within 1 day