qs_parse +0.37% instructions after 3b-ii stream/events layouts (#12708)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- rust, typescript
- Domain
- compilers, performance
Research direction
Start by comparing the instruction-level performance diff by symbol between main with #12703 and #12708, then check whether qs links node:stream/events. The reported increase is 0.37% across five runs, and the cause is unverified; determine whether code layout or another change explains it. Done means identifying the source of the instruction increase and recording whether node:stream/events is linked.
Written by the indexing model from the issue text.
Description
Fix-forward for #12708.
qs_parse instructions:u went from 9.627G to 9.663G (+0.37%), reproducible over 5 runs. Base is main with #12703 (291142de38); head is #12708 (9e16983e1e).
The cause is unexplained:
- full GC counts are equal on both arms;
- no single function accounts for the delta.
.text grew by +13.6 KB (14,247,538 to 14,261,106) from the node-exact stream/events prototype builders. Code layout from that growth is one candidate cause, but it isn't verified.
Under the perf policy (~0.5% real is OK with a fix-forward issue) this is tracked, not blocking.
Next: a perf diff by symbol at the instruction level, and a check whether qs links node:stream/events at all (it is in the +13.5 KB group).
- Dominant language
- Rust
- Stars
- 4.9k
- Forks
- 166
- Avg merge
- 2h 54m
- Merged PRs (30d)
- 922
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PerryTS/perry
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 8 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
swc-project/swc#12576 ·
Maintainers usually reply within 1 day
-
good first issue gpu serve
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day