Add in API for callback.
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
Research direction
Start by reading the callback flow described in the issue and inspect the app’s URL detection and dialog entry points. Compare the proposed same-domain validation with the x-callback-url and window.open/postMessage options, then decide which flow fits the stated constraints. Done means a callback can return results safely and the dialog presents the requested app-specific action; the issue names no files or tests.
Written by the indexing model from the issue text.
Description
It should be possible to launch the API with a callback to a URL that will post the results there
Ideal UI
- When URL detected, open up the dialog with the OPEN, CANCEL, SHARE button in
- Include a new button with the name of the app and the domain of the callback
- Ideally we should validate the callback against the referrer. So we only share back to the same domain (for now)
Some additional research
- x-callback-url http://x-callback-url.com/ (Zxing seems to use this), useful way to call back directly into the APP - we can't check the referrer though because it uses a custom scheme
- Could use an intent URL on Android and target and app, we probably want to disable this for now unless we know it is going back directly into the calling app.
window.openandpostMessageare options to send back data, it has a relatively complex API and it won't work with out JS. with x-callback-url, I could do it on the server.
Issues
x-callback-url:
- It's incrediblly hard to workout which web site called you and directly get back into the running instance of the site that invoked your app, instead you can only manage forward only requests. App->QR->App and that might mean a new page load etc, network round trips and also offline issues.
- Dominant language
- JavaScript
- Stars
- 375
- Forks
- 479
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PaulKinlan/qrcode
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
PaulKinlan/qrcode#69 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
PaulKinlan/qrcode#67 ·
-
bug on ios 12.2 only selfie caméraPossibly taken @Yuren0312 claimed this 1 day ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 15/100
PaulKinlan/qrcode#58 · 3 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 30/100
PaulKinlan/qrcode#51 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
PaulKinlan/qrcode#50 ·
All issues in PaulKinlan/qrcode
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
remotion-dev/remotion#13341 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
svix/svix-webhooks#2808 ·
Maintainers usually reply within 1 day