Screams belt shrine effect is applied to Frozen Sweep in PoB, but in game it is not

Open
#10,375 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 8 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
lua
Domain
game-dev

Research direction

Load the PoB build code at https://pobb.in/nqvLGvcT5esP and reproduce the issue with a diamond shrine belt and Frozen Legion. Compare the Frozen Sweep critical chance calculation with the in-game value, then verify that PoB no longer applies the shrine effect when the resulting values are checked.

Written by the indexing model from the issue text.

Description

bug: calculation
Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

In-game, crit chance for frozen sweep shows as 14%

Image
What is the value from the calculation in Path of Building?

100% crit in pob

How to reproduce the issue
  1. Equip a diamond shrine belt
  2. Use Frozen Legion
PoB for PoE1 build code
https://pobb.in/nqvLGvcT5esP
Screenshots

No response

Dominant language
Lua
Stars
5.5k
Forks
2.4k
Avg merge
6d 14h
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PathOfBuildingCommunity/PathOfBuilding

All issues in PathOfBuildingCommunity/PathOfBuilding

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.