Buy similar improvements ideas

Open
  • Is something wrong?
#10,282 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 8 days

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
42/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
lua
Domain
desktop, frontend

Research direction

Start by locating the Buy Similar menu and reviewing how its current filters and value boxes are assembled. Compare the existing UI with the referenced Ninja menu and determine how each requested improvement would fit; done requires an agreed, working set of the requested stat, multiplier, pseudo-filter, influence, and slider improvements.

Written by the indexing model from the issue text.

Description

enhancement
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

Our UI is worse than ninja's

Describe the solution you'd like

I think it would be a good idea to add the following to the buy similar menu:

  • Weapon pdps/edps/tdps stats. Crit is also important for e.g. PoE2 avoiding dreaming quarterstaves
  • Either a search value multiplier slider like ninja or a default multiplier like Awakened Trade / EE2
  • Min and max defaults more intelligently for e.g. cluster jewels or bad modifier values
  • Support for some pseudo filters, like open/crafted prefix/suffix instead of searching directly for a crafted mod. Searching for exact modifiers is too limiting. Having relevant pseudo stats would also be neat
  • Search for influences
  • The value boxes could also possible be sliders. But this is kind of whatever
Describe alternatives you've considered

No response

Additional context

Ninja's pretty menu for context:

Image
Dominant language
Lua
Stars
5.5k
Forks
2.4k
Avg merge
6d 14h
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PathOfBuildingCommunity/PathOfBuilding

All issues in PathOfBuildingCommunity/PathOfBuilding

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.