Displayed soul cost mismatch

Open
#10,192 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 8 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
lua
Domain
desktop

Research direction

No source file or test is named. Reproduce the mismatch with Vaal Arc and the 30% less-souls configuration, then trace the soul-cost calculation used by the left panel and calcs; done means both displays use the same rounding and show 17 or 18 consistently.

Written by the indexing model from the issue text.

Description

bug
Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

If you have a vaal skill, the soul cost on the left panel and in calcs should match.

How does Path of Building behave?

They don't always match.

How to reproduce the issue
  1. Add Vaal Arc
  2. Add the custom configuration Vaal Skills require 30% less souls per use (so soul cost is 25 * 0.7 = 17.5)
  3. Observe how on the left panel the soul cost is 17, while in the calcs it is 18
PoB for PoE1 build code

Screenshots
Image
Dominant language
Lua
Stars
5.5k
Forks
2.4k
Avg merge
6d 14h
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PathOfBuildingCommunity/PathOfBuilding

All issues in PathOfBuildingCommunity/PathOfBuilding

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.