Improve messages after upstream chunk api update
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- java
- Domain
- backend, distributed-systems
Research direction
No file or test is named in the issue. Start by locating the NMS getChunk entry point used by the Bukkit chunk API and compare it with the upstream chunk API update and existing thread checks. Done means off-thread calls correctly enforce unsupported-operation behavior while correctly used main-thread chunk objects show no change.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem?
Yes, upstream removed the cached nms chunk from craftchunk, and every call to bukkit api chunks gets the chunk every time synchronously, which is redirected into a nms method which wasn't updated by folia, so it doesn't properly check for things and throw unsupported operation exceptions.
Describe the solution you'd like.
Update the used nms getChunk method or change the method to a newer one
Describe alternatives you've considered.
use proper isTickThread check (or maybe even better ensureTickThread)
Other
The people who used chunk object correctly and only from main thread shouldn't see a difference.
- Dominant language
- Shell
- Stars
- 4.7k
- Forks
- 651
- Avg merge
- 10d 3h
- Merged PRs (30d)
- 3
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PaperMC/Folia
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
status: needs triage type: bug
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
status: needs triage type: performance
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
status: needs triage type: bug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
status: needs triage type: bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Similar issues
-
cicd
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nolte/kamerplanter-appliance#53 ·
Maintainers usually reply within 1 day
-
area:scripts priority:P2 status:backlog
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
KD5UJC-XYZ/scarab#1170 ·
Maintainers usually reply within 1 day
-
SETUP: nothing verifies the decider code was ever set, so a skipped step leaves approvals token-onlyOpen
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
mattabate/life-distributable#229 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
-
bug fixed good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
sdetweil/MagicMirror-backup-restore#20 · 1 comment ·