Improve messages after upstream chunk api update

Open
#96 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java

Research direction

No file or test is named in the issue. Start by locating the NMS getChunk entry point used by the Bukkit chunk API and compare it with the upstream chunk API update and existing thread checks. Done means off-thread calls correctly enforce unsupported-operation behavior while correctly used main-thread chunk objects show no change.

Written by the indexing model from the issue text.

Description

status: needs triage type: feature
Is your feature request related to a problem?

Yes, upstream removed the cached nms chunk from craftchunk, and every call to bukkit api chunks gets the chunk every time synchronously, which is redirected into a nms method which wasn't updated by folia, so it doesn't properly check for things and throw unsupported operation exceptions.

image
image
image

Describe the solution you'd like.

Update the used nms getChunk method or change the method to a newer one

Describe alternatives you've considered.

use proper isTickThread check (or maybe even better ensureTickThread)

Other

The people who used chunk object correctly and only from main thread shouldn't see a difference.

Dominant language
Shell
Stars
4.7k
Forks
651
Avg merge
10d 3h
Merged PRs (30d)
3

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PaperMC/Folia

All issues in PaperMC/Folia

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.